Skip to content

Comments

Upgrade dependencies, use useSetAtom, use correct AppConfig#19

Open
friedger wants to merge 2 commits intoboomcrypto:mainfrom
friedger:chore/upgrade-deps
Open

Upgrade dependencies, use useSetAtom, use correct AppConfig#19
friedger wants to merge 2 commits intoboomcrypto:mainfrom
friedger:chore/upgrade-deps

Conversation

@friedger
Copy link
Member

This PR

  • update dependencies
  • replaces useUpdateAtom with useSetAtom
  • replaces package of AppConfig

@whoabuddy whoabuddy self-requested a review June 14, 2023 19:17
Copy link
Collaborator

@whoabuddy whoabuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!! It'd be great to be able to access more recent features with all these updated packages.

I'm having trouble building / running this locally though:

yarn install gives me a few new warnings, but still succeeds:

  • turns out the warnings here were also in the old code, so can disregard

yarn start errors out though and shows a blank screen. maybe you have something globally that we don't have in the package.json?

Failed to compile.

Error: [BABEL] /home/whoabuddy/Dev/boom/citycoins-ui/src/index.js: Cannot find module '@babel/plugin-proposal-async-generator-functions'

Will test adding what's missing and report back.

"c32check": "2.0.0",
"jotai": "2.1.0",
"lodash.groupby": "4.6.0",
"number-to-words": "github:OmgImAlexis/number-to-words",
Copy link
Collaborator

@whoabuddy whoabuddy Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this while we're at it (L34: number-to-words)

@whoabuddy
Copy link
Collaborator

Following up - I eventually got it to run but don't understand why it was such a hassle, plus some of the layout seems to have shifted up by the logos.

Were you seeing this run normally on your end? I'm happy to nuke my config and start over if I missed something. More details below.


React version I'm using via nvm: v18.12.1

I had to update the pacakge.json start script otherwise it would error out:

│ 45 │    "start": "react-scripts --openssl-legacy-provider start",

I also had to add a bunch of dev dependencies:

"@babel/core": "^7.22.5",
"@babel/plugin-proposal-dynamic-import": "^7.18.6",
"@babel/plugin-proposal-export-namespace-from": "^7.18.9",
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
"@babel/plugin-syntax-async-generators": "^7.8.4",
"@babel/plugin-syntax-class-properties": "^7.12.13",
"@babel/plugin-syntax-flow": "^7.22.5",
"@babel/plugin-syntax-json-strings": "^7.8.3",
"@babel/plugin-syntax-logical-assignment-operators": "^7.10.4",
"@babel/plugin-syntax-object-rest-spread": "^7.8.3",
"@babel/plugin-syntax-optional-catch-binding": "^7.8.3",
"@babel/plugin-transform-react-jsx": "^7.22.5",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants