[FEAT/#122] 스토리 몰입모드 구현 및 배경 변경 #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haeti-dev
requested review from
Ameri-Kano,
TaewoongR and
shinythinking
and removed request for
a team
TaewoongR
approved these changes
Dec 5, 2024
| modifier: Modifier = Modifier, | ||
| progress: Float, | ||
| backgroundColor: Color = Color.Gray, | ||
| backgroundColor: Color = Color.White, |
Comment on lines
+28
to
+54
| DisposableEffect(Unit) { | ||
| // 몰입 모드 활성화 | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) { | ||
| val windowInsetsController = window?.insetsController | ||
| windowInsetsController?.systemBarsBehavior = | ||
| WindowInsetsController.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE | ||
| windowInsetsController?.hide(WindowInsets.Type.systemBars()) | ||
| } else { | ||
| @Suppress("DEPRECATION") | ||
| window?.decorView?.systemUiVisibility = ( | ||
| View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY | ||
| or View.SYSTEM_UI_FLAG_FULLSCREEN | ||
| or View.SYSTEM_UI_FLAG_HIDE_NAVIGATION | ||
| ) | ||
| } | ||
|
|
||
| onDispose { | ||
| // 몰입 모드 비활성화 | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) { | ||
| val windowInsetsController = window?.insetsController | ||
| windowInsetsController?.show(WindowInsets.Type.systemBars()) | ||
| } else { | ||
| @Suppress("DEPRECATION") | ||
| window?.decorView?.systemUiVisibility = View.SYSTEM_UI_FLAG_VISIBLE | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
DisposableEffect 는 LaunchedEffect 랑 다르게 coroutineScope을 사용하지 않네요.
컴포지션 끝나면 onDispose 호출해서 비활성화 되는 부분 좋은 사용의 예시라고 생각드네요!
Collaborator
There was a problem hiding this comment.
DisposableEffect 라는 게 있군요! Composable 함수가 종료될 때 사용할 수 있는 함수로 라이프사이클에 따르면 onStop 과 onDestroy 사이에 onDispose가 호출된다고 하네요!
Ameri-Kano
approved these changes
Dec 5, 2024
Comment on lines
+28
to
+54
| DisposableEffect(Unit) { | ||
| // 몰입 모드 활성화 | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) { | ||
| val windowInsetsController = window?.insetsController | ||
| windowInsetsController?.systemBarsBehavior = | ||
| WindowInsetsController.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE | ||
| windowInsetsController?.hide(WindowInsets.Type.systemBars()) | ||
| } else { | ||
| @Suppress("DEPRECATION") | ||
| window?.decorView?.systemUiVisibility = ( | ||
| View.SYSTEM_UI_FLAG_IMMERSIVE_STICKY | ||
| or View.SYSTEM_UI_FLAG_FULLSCREEN | ||
| or View.SYSTEM_UI_FLAG_HIDE_NAVIGATION | ||
| ) | ||
| } | ||
|
|
||
| onDispose { | ||
| // 몰입 모드 비활성화 | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) { | ||
| val windowInsetsController = window?.insetsController | ||
| windowInsetsController?.show(WindowInsets.Type.systemBars()) | ||
| } else { | ||
| @Suppress("DEPRECATION") | ||
| window?.decorView?.systemUiVisibility = View.SYSTEM_UI_FLAG_VISIBLE | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
DisposableEffect 라는 게 있군요! Composable 함수가 종료될 때 사용할 수 있는 함수로 라이프사이클에 따르면 onStop 과 onDestroy 사이에 onDispose가 호출된다고 하네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 Work Description
📸 Screenshot
default.mp4
📢 To Reviewers
⏲️Time