feat: add pitched instrument selection#22
Merged
Conversation
This was referenced Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #19
Adds clip-level pitched instrument lanes for
Default SynthandIowa Piano, with note events owned by serializableinstrumentIdvalues so both instruments can coexist and play together in one clip.Changes
Default SynthandIowa Piano.instrumentIdto serializableNoteEventdata and filters the visible piano roll notes by the selected sidebar instrument.Default SynthandIowa Pianoto sound simultaneously.decodeAudioDatacannot decode a bundled WAV.sampleStartSecondsoffsets so Iowa Piano playback skips leading silence in the bundled one-second WAV files.Testing
npm run typecheck --if-presentnpm run lint --if-presentnpm run test --if-presentnpm run build --if-presentScreenshots
Not included. Dev server was previously started and the app returned HTTP 200 at
http://127.0.0.1:5174/because port 5173 was already in use.Notes / Limitations
AudioBufferSourceNode.loop.Follow-up