feat: add sampler sustain playback#29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #23
Adds a reusable sampler sustain path for sample-based pitched instruments. Iowa Piano now uses serializable sample-zone sustain metadata and the browser audio engine validates that metadata at runtime before enabling native Web Audio forward looping.
Changes
SampleZone.sustain,SampleZone.envelope, andsampleEndSecondsmetadata shape for sample-based pitched instruments.src/audio/sampler-sustain.tswith pure helpers for playback plan resolution, loop validation, envelope clamping, and transport release timing.BrowserAudioEngineto schedule sampled notes through the shared sampler plan instead of flat Iowa-specific loop fields.Testing
npm run typecheck --if-presentnpm run lint --if-presentnpm run test --if-presentnpm run build --if-presentAdditional checks:
git diff --checkhttp://127.0.0.1:5174/with HTTP 200 because port5173was occupied.Screenshots
No UI changes.
Notes / Limitations
crossfade-loopmetadata is recognized as serializable metadata but intentionally falls back to one-shot behavior until a future task implements and tests overlapping crossfade sources.Follow-up