feat: import WAV files as audio clips#45
Merged
Conversation
0826911 to
75153ba
Compare
75153ba to
c22796e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements WAV file import as audio clips from the sidebar clip add flow, including selected-clip loop preview playback.
Closes #39.
Changes
Build a clip/Import a filemenu to the sidebar clip add button.AudioClip/SampleMetamodel types and made the app clip collection support hybrid and audio clips.File,Blob, object URLs, orAudioBufferin serializable clip data.Build a clip.Testing
npm run typecheck --if-presentnpm run lint --if-presentnpm run test --if-presentnpm run build --if-presentgit diff --checkcurl -I http://127.0.0.1:5174/Screenshots
Not captured in this environment.
Notes / Limitations
Follow-up
AudioClipshape when adding arrangement clip placement/playback.