[fix] /admin routes should trust requireAdmin, not Edge middleware#43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
/admin/members가 404 로 가는 문제 수정.원인
middleware.ts가 Edge-safeauthConfig로/admin/*에서role !== 'ADMIN'를 판정하고 있었음. 그런데 Edge 쪽req.auth.user.role은 DB fresh fetch 를 안 하므로 stale 하거나 비어 있을 수 있음. 실제 page 는requireAdmin()이 DB 기준으로 제대로 판정하는데, 그 전에 middleware 가/404-not-found로 rewrite 해서 관리자도 막힘.수정
/admin/*차단 제거/admin/*권한 판정은 page/action 진입점의requireAdmin()에만 맡김검증
pnpm check통과/admin/members진입 가능해야 함requireAdmin()에서 notFound 처리됨