lcov report

[sdarwin]

No description provided.

[jeking3]

We're disabling GitHub Actions completely?

[Flamefire]

To make this easier you could use either text+= or just change quotes like

text='use=41"'\
"$variable"'
$non-evaled'

Or use a here-doc and sed with placeholders

[sdarwin]

Yes, instead of textpart1 textpart2 textpart3 , and then joining them together, perhaps it all be one monolithic here-doc. Originally, I tried to design it all as one large variable. Then having difficulty embedded variables inside variables, and dealing with multiple quotes inside quotes. So, broke it apart into pieces. That simplified it.

If you strongly prefer to push them all back into one variable again, and be certain it works, with all the quotes and interpolations, then you can modify this PR, or submit another PR, and I will agree. Or, it can stay as-is, I believe it's ok.

[Flamefire]

I was thinking about how to improve this string creation to be "clean".
In the end I think it would be cleanest to NOT have this string at all:

• add ci/runcodecov.sh as a regular script file
• before git submodule foreach export the 2 required variables from this script (SKIPLIST & LCOV_SKIP_PATTERN)
• alternatively pass those as arguments for better visibility and fetch them at the start of the script

Having the script separate allows for easier development, linting (I see you also use shellcheck) and manual execution for focused testing

BTW: I'd suggest to always use set -eu at the top of the scripts to detect misspelled variables, missing parameters and unexpectedly failing commands

[sdarwin]

We're disabling GitHub Actions completely?

@jeking3 , these reports are on a separate branch "feature/reports", to not confuse drone files of the master branch, which are example files for end users.
There is no point in triggering GHA, since that is done on the main branch.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (63644bc) to head (142c63d).
Report is 6 commits behind head on feature/reports.

❗ There is a different number of reports uploaded between BASE (63644bc) and HEAD (142c63d). Click for more details.

HEAD has 11 uploads less than BASE

Flag	BASE (63644bc)	HEAD (142c63d)
	12	1

Additional details and impacted files

@@                 Coverage Diff                  @@
##           feature/reports     #270       +/-   ##
====================================================
- Coverage           100.00%   88.23%   -11.77%     
====================================================
  Files                    2        2               
  Lines                   22       17        -5     
  Branches                11        0       -11     
====================================================
- Hits                    22       15        -7     
- Misses                   0        2        +2     

see 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63644bc...142c63d. Read the comment docs.

[Flamefire]

I was thinking about how to improve this string creation to be "clean".
In the end I think it would be cleanest to NOT have this string at all:

• add ci/runcodecov.sh as a regular script file
• before git submodule foreach export the 2 required variables from this script (SKIPLIST & LCOV_SKIP_PATTERN)
• alternatively pass those as arguments for better visibility and fetch them at the start of the script

Having the script separate allows for easier development, linting (I see you also use shellcheck) and manual execution for focused testing

BTW: I'd suggest to always use set -eu at the top of the scripts to detect misspelled variables, missing parameters and unexpectedly failing commands