Skip to content

Use bdde-multiarch to setup qemu for multiarch #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Conversation

jeking3
Copy link
Collaborator

@jeking3 jeking3 commented Mar 26, 2025

See jeking3/bdde#10 for details. I upgraded bdde to v3.1.0, and changed how qemu is configured. Sadly the multiarch/qemu-user-static project hasn't been updated since 2023. I reached out to one of the authors.

The job that matters here is the s390x big-endian one... it would be the only one affected by this change.

This will fix https://github.com/cppalliance/decimal/actions/runs/14069869895

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (605750a) to head (55d6dff).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #275   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           22        22           
  Branches        12        12           
=========================================
  Hits            22        22           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605750a...55d6dff. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeking3 jeking3 requested a review from Flamefire March 26, 2025 12:03
@Flamefire Flamefire merged commit 9387665 into master Mar 26, 2025
67 checks passed
@Flamefire
Copy link
Collaborator

Great, thanks!

@Flamefire Flamefire deleted the multiarch-fix branch March 26, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants