Change check for 128 bit integers

mborland · mborland · commit 7960682428f7 · 2025-06-25T11:32:41.000-04:00
diff --git a/include/boost/charconv/detail/from_chars_integer_impl.hpp b/include/boost/charconv/detail/from_chars_integer_impl.hpp
@@ -186,8 +186,11 @@ BOOST_CXX14_CONSTEXPR from_chars_result from_chars_integer_impl(const char* firs
         }
     }
 
-    #ifdef BOOST_CHARCONV_HAS_INT128
-    BOOST_IF_CONSTEXPR (std::is_same<Integer, boost::int128_type>::value)
+    BOOST_IF_CONSTEXPR ((std::numeric_limits<Integer>::is_signed && sizeof(Integer) == 16)
+                        #ifdef BOOST_CHARCONV_HAS_INT128
+                        || std::is_same<boost::int128_type, Integer>::value
+                        #endif
+                        )
     {
         overflow_value /= unsigned_base;
         max_digit %= unsigned_base;
@@ -200,7 +203,6 @@ BOOST_CXX14_CONSTEXPR from_chars_result from_chars_integer_impl(const char* firs
         #endif
     }
     else
-    #endif
     {
         overflow_value /= unsigned_base;
         max_digit %= unsigned_base;

Original file line number	Diff line number	Diff line change
`@@ -186,8 +186,11 @@ BOOST_CXX14_CONSTEXPR from_chars_result from_chars_integer_impl(const char* firs`
`186`	`186`	`}`
`187`	`187`	`}`
`188`	`188`
`189`		`- #ifdef BOOST_CHARCONV_HAS_INT128`
`190`		`- BOOST_IF_CONSTEXPR (std::is_same<Integer, boost::int128_type>::value)`
	`189`	`+ BOOST_IF_CONSTEXPR ((std::numeric_limits<Integer>::is_signed && sizeof(Integer) == 16)`
	`190`	`+ #ifdef BOOST_CHARCONV_HAS_INT128`
	`191`	`+ \|\| std::is_same<boost::int128_type, Integer>::value`
	`192`	`+ #endif`
	`193`	`+ )`
`191`	`194`	`{`
`192`	`195`	`overflow_value /= unsigned_base;`
`193`	`196`	`max_digit %= unsigned_base;`
`@@ -200,7 +203,6 @@ BOOST_CXX14_CONSTEXPR from_chars_result from_chars_integer_impl(const char* firs`
`200`	`203`	`#endif`
`201`	`204`	`}`
`202`	`205`	`else`
`203`		`- #endif`
`204`	`206`	`{`
`205`	`207`	`overflow_value /= unsigned_base;`
`206`	`208`	`max_digit %= unsigned_base;`