Skip to content

Suppress build: masm logo and clang warning argument unused during compilation #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

Challanger524
Copy link
Contributor

@Challanger524 Challanger524 commented Jan 29, 2025

PR for: #286 and #287

Concern

These changes are applied to implementation fcontext (that is being set for me):

[build] -- Boost.Context: architecture x86_64, binary format pe, ABI ms, assembler gas, suffix .asm, implementation fcontext

Maybe old code + new mine should affect other implementations (ucontext, winfib) too, maybe not - I don't know.

Further

There still MASM output that informs/repeats the build file, looks like modern VS 2022 17.7 Preview 1 is able to consume /quiet option for ml and ml64. But it is too modern :(
https://gitlab.kitware.com/cmake/cmake/-/issues/23537#note_1316785

/quiet Suppresses 'Assembling' message. Available in Visual Studio 17.6 and later.

https://learn.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=msvc-170

Version table

https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170#version-macros

Visual Studio 2022 version 17.5 1935
Visual Studio 2022 version 17.6 1936
Visual Studio 2022 version 17.7 1937

CMake - GREATER_EQUAL

Added in version 3.7: Added the LESS_EQUAL and GREATER_EQUAL options.
And context is 3.5: if(NOT(MSVC_VERSION LESS 1936)) will it be
https://stackoverflow.com/questions/16667017/cmake-express-the-greater-or-equal-statement

Concern

It is better to check if we can pass /quiet on any 17.6 patch version, or better to set 1937 to be 100% sure that it works.

@Challanger524 Challanger524 force-pushed the suppress-odd-build-output branch 2 times, most recently from 93147a5 to e58035d Compare January 29, 2025 17:54
@Challanger524 Challanger524 force-pushed the suppress-odd-build-output branch from e58035d to f6726cc Compare January 30, 2025 14:36
@olk olk merged commit 1fd62ab into boostorg:develop Feb 21, 2025
3 checks passed
@olk
Copy link
Member

olk commented Feb 21, 2025

ty

@Challanger524
Copy link
Contributor Author

Just pulled updated boost/context with my PR fixes. It is so awesome to see those same fixes working without any local changes! Thank you for reviewing (hope it was reviewed) and somehow tested, since I don't see any CMake related CI/CD Actions.

@marakew
Copy link

marakew commented Feb 21, 2025

catch issue #293

@Challanger524
Copy link
Contributor Author

Challanger524 commented Apr 16, 2025

#294 PR fixing cmake logic for Clang-CL (MSVC frontend)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants