Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cmake support to examples #1313

Merged
merged 2 commits into from
Sep 30, 2024
Merged

feat: add cmake support to examples #1313

merged 2 commits into from
Sep 30, 2024

Conversation

barendgehrels
Copy link
Collaborator

  • replace BOOST_FOREACH

  • replace Boost.Assign

  • replace typedef with using

  • other minor changes

@barendgehrels barendgehrels self-assigned this Sep 26, 2024
vissarion
vissarion reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, and modernization! Thanks!

I have only a question. Also it seems that something is missing and some examples cannot be compiled in CI.

doc/src/examples/algorithms/CMakeLists.txt Show resolved Hide resolved
@barendgehrels
feat: add cmake support to examples
532743b 
- replace BOOST_FOREACH

- replace Boost.Assign

- replace typedef with using

- other minor changes
@barendgehrels
Copy link
Collaborator Author

Great addition, and modernization! Thanks!

I have only a question. Also it seems that something is missing and some examples cannot be compiled in CI.

Indeed, will handle. Thanks.

@barendgehrels
Copy link
Collaborator Author

I have only a question. Also it seems that something is missing and some examples cannot be compiled in CI.

Indeed, will handle. Thanks.

✅

vissarion
vissarion approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, now all examples (except from problematic ones where comments are inserted) are included and the test are passing.

@barendgehrels barendgehrels merged commit 310498b into boostorg:develop Sep 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vissarion vissarion vissarion approved these changes

@mloskot mloskot Awaiting requested review from mloskot

@awulkiew awulkiew Awaiting requested review from awulkiew

Assignees

@barendgehrels barendgehrels

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barendgehrels @vissarion