Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Boost.Bind usages. #418

Merged

Conversation

gogagum
Copy link
Contributor

@gogagum gogagum commented Feb 11, 2025

This PR replaces boost::bind usages with lambdas, so Boost.Bind can be removed from dependances.

@gogagum
Copy link
Contributor Author

gogagum commented Feb 11, 2025

I will make an attempt of doing some workaronds for Clang.

@gogagum gogagum force-pushed the feature/remove-boost-bind-usages branch 2 times, most recently from 454863f to 7d7c035 Compare February 11, 2025 21:31
@jeremy-murphy
Copy link
Contributor

Thanks for your effort to improve Boost.Graph, it's really appreciated!
However, I strongly recommend you watch this video about bind and then consider what change you want to make: https://youtu.be/zt7ThwVfap0?si=47AbaJkWFh-VrnBc

@gogagum
Copy link
Contributor Author

gogagum commented Feb 11, 2025

Well, the speaker recommends to avoid std::bind. Do you mean this? I just tried to replace boost::bind with std::bind where possible to make minimal difference. It is not a problem to replace all std::bind usages with lambdas.

@jeremy-murphy
Copy link
Contributor

Well, the speaker recommends to avoid std::bind. Do you mean this? I just tried to replace boost::bind with std::bind where possible to make minimal difference. It is not a problem to replace all std::bind usages with lambdas.

Yeah, I think replacing one bind with another is not really worth doing when it could be replaced with something even better.

@gogagum gogagum marked this pull request as draft February 12, 2025 10:12
@gogagum gogagum force-pushed the feature/remove-boost-bind-usages branch from 4329a27 to 3da5cba Compare February 15, 2025 15:34
@gogagum gogagum marked this pull request as ready for review February 15, 2025 16:00
@jeremy-murphy
Copy link
Contributor

I requested changes, but really they're just questions/suggestions. This code is good to go if there is a reason for everything.

@gogagum gogagum force-pushed the feature/remove-boost-bind-usages branch from 3da5cba to 2d182cf Compare February 17, 2025 18:14
@jeremy-murphy jeremy-murphy merged commit d5531e2 into boostorg:develop Feb 18, 2025
22 checks passed
@jeremy-murphy
Copy link
Contributor

Great, thanks for this improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants