Unsigned integral constants are not EuclideanRings #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldionne
force-pushed
the
pr/issue-240
branch
from
be252aa to
376deef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix #240. Unfortunately, this is a potentially breaking change, so it will have to wait until I'm ready to bump the major version. In addition, it introduces additional problems, like the fact that we can't write
size_c<n> % size_c<k>(because they're notEuclideanRings), but we also can't writeint_c<n> % size_c<k>, since they don't have the same signedness. This is very annoying, and all of this pushes me in the direction where I just want a dumbIntegralConstantconcept with only syntactical requirements, no semantics.When I'm ready to bump the major version (i.e. when we have a sufficiently large amount of breaking changes to make at once), I'll either close this PR (if I remove numeric concepts) or fix this PR and merge it.