Skip to content

Conversation

@anonymouspc
Copy link
Contributor

Header src/shared/mo_hash.hpp is unguarded.

Most times it works. But recently I'm trying to compile boost/locale into a C++20 module. I found this file better be guarded in this compiling-case, as C++20 module treats function-declarations in .hpp files as translatable ones (which cannot be multi-defined).

One tiny change: #ifdef xxx #define xxx to make header mo_hash.hpp guarded.

Thank you!
This is an amazing library and I will start it :)

Copy link
Collaborator

@Flamefire Flamefire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

If you get the module working please reach out to the Boost mailing list as there have been discussions on how to best approach this

@Flamefire Flamefire enabled auto-merge June 16, 2025 07:42
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (d6e3119) to head (7155f6d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #262   +/-   ##
========================================
  Coverage    95.96%   95.96%           
========================================
  Files          119      119           
  Lines        10611    10611           
========================================
  Hits         10183    10183           
  Misses         428      428           
Files with missing lines Coverage Δ
src/shared/mo_hash.hpp 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e3119...7155f6d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Flamefire Flamefire disabled auto-merge June 17, 2025 08:27
@Flamefire Flamefire merged commit cfb7236 into boostorg:develop Jun 17, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants