Fix cygwin tests #267
Merged
Fix cygwin tests #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
test-improvement
branch
4 times, most recently
from
9291940 to
8f99a63
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #267 +/- ##
===========================================
+ Coverage 95.76% 95.93% +0.17%
===========================================
Files 119 119
Lines 10331 10370 +39
===========================================
+ Hits 9893 9948 +55
+ Misses 438 422 -16
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Flamefire
force-pushed
the
test-improvement
branch
12 times, most recently
from
f7aa74e to
75d231a
Compare
Avoid subsequent failure reports if the parsing already failed
They are supersets in that they replace unassigned ranges or control characters by valid symbols. This is slightly better than the fallback to the classic/C locale.
Flamefire
force-pushed
the
test-improvement
branch
from
2b0d855 to
89a3ed8
Compare
Flamefire
force-pushed
the
test-improvement
branch
7 times, most recently
from
a6d3c98 to
7651077
Compare
Handle that the same as for native Windows. Reason is an issue discovered converting an UTF-8 sequence of 1000x U+2008A to wchar_t (UTF-16): UTF-8: "\xF0\xA0\x82\x8A" The correct result are 1000x L"\xD840\xDC8A" The first 255 pairs are correct (1020 input bytes consumed) but the low surrogate of the 256th pair becomes `0xDC82` hinting it repeats the second last byte (index 1023) instead of reading the correct one.
Flamefire
force-pushed
the
test-improvement
branch
from
08a0528 to
2690f0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve tests so they pass on Appveyor Cygwin again