Skip to content

Handle issue 1255 and update docs #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2025
Merged

Handle issue 1255 and update docs #1256

merged 4 commits into from
Apr 12, 2025

Conversation

ckormanyos
Copy link
Member

No description provided.

@ckormanyos
Copy link
Member Author

See also #1255

@ckormanyos
Copy link
Member Author

Something weird is happening in CI, in this PR and also in the CI that ran when @mborland simply incremented the library version here.

It seems like something is influencing files that were not touched in the changes.

Cc: @jzmaddock

@ckormanyos
Copy link
Member Author

For some reason, when exceptions are off at compilation time, we are hitting this line. Then certain tests in the Math test suite fail when Boost has no exceptions yet this file is still included.

That line is, however, two years old. I wonder what tiny change and where causes this phenomenon today?

@ckormanyos
Copy link
Member Author

ckormanyos commented Apr 12, 2025

Hmmm I don't know so much about the dependencies in the Jamfile. But why is Math's test suite trying to build the libboost_exception.a archive here?

This is in the recent version increment from @mborland

@jzmaddock
Copy link
Collaborator

There is some cruft in the Jamfile, but there are other issues too. I'm working through them in #1254, it's getting closer to green, but there are no cigars being lit just yet!

@ckormanyos
Copy link
Member Author

some cruft in the Jamfile, but there are other issues too. I'm working through them in #1254, it's getting closer to green,

Thanks John. OK cool. I'll hold my horses a bit and wait till that goes green and gets in develop.

In the meantime, I'll try to ensure that the new tests for #1255 are all passing.

Copy link

codecov bot commented Apr 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.83%. Comparing base (e818106) to head (76dede0).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1256   +/-   ##
========================================
  Coverage    93.83%   93.83%           
========================================
  Files          657      658    +1     
  Lines        55244    55256   +12     
========================================
+ Hits         51840    51852   +12     
  Misses        3404     3404           
Files with missing lines Coverage Δ
.../boost/math/special_functions/detail/bessel_yn.hpp 100.00% <100.00%> (ø)
test/git_issue_1255.cpp 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e818106...76dede0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ckormanyos
Copy link
Member Author

It it is good enough for #1254, it's good enough for #1255, with the repeated comment, OK looks good to go, only failures are from cycl Cauchy tests.

We'll let @mborland look at those.

@ckormanyos ckormanyos merged commit 6ba549b into develop Apr 12, 2025
80 of 81 checks passed
@ckormanyos ckormanyos deleted the issue1255 branch April 12, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants