Skip to content

Collected fixes for incomplete beta in the asymptotic large a/b region #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 14, 2025

Conversation

jzmaddock
Copy link
Collaborator

Fixes #1198.

This change introduces some rather extreme new test cases, expect CI carnage!

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (e818106) to head (e8c86a8).
Report is 17 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1257   +/-   ##
========================================
  Coverage    93.83%   93.84%           
========================================
  Files          657      658    +1     
  Lines        55244    55295   +51     
========================================
+ Hits         51840    51891   +51     
  Misses        3404     3404           
Files with missing lines Coverage Δ
...lude/boost/math/distributions/non_central_beta.hpp 92.09% <100.00%> (ø)
include/boost/math/special_functions/beta.hpp 100.00% <100.00%> (ø)
.../boost/math/special_functions/detail/bessel_ik.hpp 99.44% <100.00%> (ø)
test/test_ibeta.cpp 97.91% <100.00%> (+0.41%) ⬆️
test/test_ibeta.hpp 99.03% <100.00%> (+0.01%) ⬆️
test/test_nc_f.cpp 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e818106...e8c86a8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jzmaddock
Copy link
Collaborator Author

Just the sycl tests failing so merging...

@jzmaddock jzmaddock merged commit ddd8032 into develop Apr 14, 2025
80 of 81 checks passed
@dschmitz89
Copy link
Contributor

Thanks @jzmaddock ! Do you expect this to also close scipy/scipy#21725 ? Another case of large a and b.

@dschmitz89
Copy link
Contributor

Thanks @jzmaddock ! Do you expect this to also close scipy/scipy#21725 ? Another case of large a and b.

Looks like it does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noncentral F distribution CDF edge cases
2 participants