Skip to content

Fix for inverse ibeta with large a,b. #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025
Merged

Fix for inverse ibeta with large a,b. #1259

merged 3 commits into from
Apr 17, 2025

Conversation

jzmaddock
Copy link
Collaborator

In this case Temme's method may fail as the incomplete gamma can't cope, but as the function changes over from 0 to 1 very rapidly, we can just use the saddle point as a reasonable starting location for iteration. See scipy/scipy#21725.

In this case Temme's method may fail as the incomplete gamma can't cope, but as the function changes over from 0 to 1 very rapidly, we can just use the saddle point as a reasonable starting location for iteration.
See scipy/scipy#21725.
Add better calculation for y.
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (a2fbc93) to head (deb4391).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1259   +/-   ##
========================================
  Coverage    93.84%   93.84%           
========================================
  Files          658      658           
  Lines        55295    55299    +4     
========================================
+ Hits         51891    51895    +4     
  Misses        3404     3404           
Files with missing lines Coverage Δ
...st/math/special_functions/detail/ibeta_inverse.hpp 93.26% <100.00%> (+0.04%) ⬆️
test/test_ibeta_inv.hpp 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2fbc93...deb4391. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jzmaddock jzmaddock merged commit 1290be6 into develop Apr 17, 2025
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant