Correct slack activity miscount from fetch_slack_activity #2056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number for the messages in the boost-beast2 slack channel in the release reports that didn't make sense had been noticed.
fetch_slack_activitywasn't properly accounting for multiple pages so the last update time for a channel would be from the first page of results, meaning when it moved to newer pages the last updated time wasn't accurately reflected. would have been visible only on high traffic channels.This PR corrects that.It also
For this to work
clear_slack_activity --confirmshould be run on the server, then we can wait for the dailyfetch_slack_activityrun to execute as normal. It takes a long time, not worth forcing.