Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: Really remove empty /etc/resolv.conf and /etc/hostname #1167

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

cgwalters
Copy link
Collaborator

The previous change here was a no-op for two reasons:

  • It's actually usr/etc at this point
  • We were operating on the wrong rootfs

Fixes: 57bd0dc

The previous change here was a no-op for two reasons:

- It's actually usr/etc at this point
- We were operating on the wrong rootfs

Fixes: bootc-dev@57bd0dc
Signed-off-by: Colin Walters <[email protected]>
@cgwalters
Copy link
Collaborator Author

Hmm the LBI test failure there looks like some kind of networking flake between the controller and target. Let's see if the aarch64 runs green, if so I think we can just merge over red since I still don't know how to retry testing farm jobs other than force pushing, which retriggers everything.

And BTW what I really messed up here originally is that stuff under tests/readonly doesn't run unless it starts with test- so we were just silently not running that test before 🙈

@cgwalters cgwalters requested a review from jeckersb March 5, 2025 20:44
@jeckersb
Copy link
Contributor

jeckersb commented Mar 5, 2025

Hmm the LBI test failure there looks like some kind of networking flake between the controller and target. Let's see if the aarch64 runs green, if so I think we can just merge over red since I still don't know how to retry testing farm jobs other than force pushing, which retriggers everything.

And BTW what I really messed up here originally is that stuff under tests/readonly doesn't run unless it starts with test- so we were just silently not running that test before 🙈

I just retriggered it, you can do it from the github UI

Copy link
Contributor

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, hopefully the re-run x86_64 integration passes and this merges 🙏

@cgwalters cgwalters merged commit 60b73be into bootc-dev:main Mar 5, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants