Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internals: Add new (experimental) bootc internals fsck #1178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cgwalters
Copy link
Collaborator

Split this out of the fsverity PR.

We obviously want a fsck command. This starts by doing just two checks:

  • A verification of etc/resolv.conf; this tests 98995f6
  • Just run ostree fsck

But obvious things we should be adding here are:

  • Verifying kargs
  • Verifying LBIs

etc.

Split this out of the fsverity PR.

We obviously want a `fsck` command. This starts by doing
just two checks:

- A verification of `etc/resolv.conf`; this tests
  bootc-dev@98995f6
- Just run `ostree fsck`

But obvious things we should be adding here are:

- Verifying kargs
- Verifying LBIs

etc.

Signed-off-by: Colin Walters <[email protected]>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 7, 2025
@cgwalters cgwalters changed the title internals: Add new bootc internals fsck internals: Add new (experimental) bootc internals fsck Mar 7, 2025
Copy link
Contributor

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit about the header that is not a blocker

@@ -0,0 +1,128 @@
//! # Write deployments merging image with configmap
//!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy/paste header leftover from deploy.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants