lints: Add --no-truncate flag to bootc container lint #1324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prep for lint truncation improvement. - Kill the handling of the "max 0" case, it's pathological; this requires passing NonZeroUsize - Drop the requirement for the iterator to be clonable as it improves ergonomics, and return a vector of the collected elements instead Signed-off-by: Colin Walters <[email protected]>
Useful when running automatic reports and analyses where all issues need to be visible at once without truncation. To do this we needed to add a LintExecutionConfig to propagate configuration through the lint system. Also, refactor how we print things so there's a shared helper functions for consistent formatting with and without truncation. Closes: bootc-dev#1260 Signed-off-by: Colin Walters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful when running automatic reports and analyses
where all issues need to be visible at once without truncation.
To do this we needed to add a LintExecutionConfig to
propagate configuration through the lint system.
Also, refactor how we print things so there's a
shared helper functions for consistent formatting with and without truncation.
Closes: #1260