composefs: Read manifest+config from composefs repo instead of .imginfo#2044
Draft
cgwalters wants to merge 3 commits intobootc-dev:mainfrom
Draft
composefs: Read manifest+config from composefs repo instead of .imginfo#2044cgwalters wants to merge 3 commits intobootc-dev:mainfrom
cgwalters wants to merge 3 commits intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors how container image manifest and configuration are handled for composefs deployments. Instead of storing them in a separate .imginfo file, the manifest digest is now stored in the .origin file, and the manifest/config are read directly from the composefs repository. This is a good improvement that centralizes image metadata storage. The changes are consistent across the codebase, and backward compatibility for older deployments with .imginfo files is maintained. I've found one area for improvement regarding repository handling efficiency.
cgwalters
force-pushed
the
prep-composefs-manifest
branch
2 times, most recently
from
0d8ac87 to
ef5cb0f
Compare
Needed for handling GC later. Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
Update to the latest API here, just on general principle since it gives us logging info which we use. Assisted-by: OpenCode (Claude Opus 4) Signed-off-by: Colin Walters <walters@verbum.org>
The latest composefs-rs stores manifest and config objects and the manifest becomes a GC root, so we can use that instead of `.imginfo` sidecar files. The flow now is: bootloader entry -> deployment -> origin file -> manifest digest -> manifest -> [config | objects] For backward compatibility, fall back to the legacy .imginfo file if the .origin does not contain a manifest_digest key. Drop the really old hacky fallback that did network fetches. Note the manifest becomes part of the GC root. Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
prep-composefs-manifest
branch
from
ef5cb0f to
d1f366d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sticking this as draft for now