Recognize .md files in theme roots as templates - #24
Open
tomas wants to merge 1 commit into
Open
Conversation
The API now accepts .md files alongside .json/.yml at the theme root; teach FSTheme to classify them as templates so pull/push/sync/watch pick them up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mdfiles at the theme root, alongside.json/.yml.FSThemeclassified root files by extension viaTEMPLATE_PATTERNS/TEMPLATE_PATH_REGEX, which didn't include.md, so local.mdfiles at a theme root were silently ignored bypull/push/sync/watch..mdto both the glob patterns and the path regex used for classification.Test plan
bundle exec rspec spec/themes/fs_theme_spec.rb— added a fixturereadme.mdand a dedicated test asserting.mdroot files are recognized as templates.bundle exec rspec spec/themes/{fs_theme,mem_theme,missing_items_theme,updated_theme}_spec.rb— all pass.🤖 Generated with Claude Code