-
-
Notifications
You must be signed in to change notification settings - Fork 12
Global Api & Tools refactoring #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
boozook
wants to merge
147
commits into
main
Choose a base branch
from
api-refactoring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Automated build pre-built bindings for 2.6.2 on Linux-X64 with features: full * Automated build pre-built bindings for 2.6.2 on macOS-ARM64 with features: default * Automated build pre-built bindings for 2.6.2 on macOS-ARM64 with features: full * Automated build pre-built bindings for 2.6.2 on Linux-X64 with features: default * Automated build pre-built bindings for 2.6.2 on Windows-X64 with features: full * Automated build pre-built bindings for 2.6.2 on Windows-X64 with features: default * Automated bump sys crate version --------- Co-authored-by: Update Bot <boozook@users.noreply.github.com>
* Automated build pre-built bindings for 2.6.0 on macOS-ARM64 with features: default * Automated build pre-built bindings for 2.6.0 on macOS-ARM64 with features: full * Automated build pre-built bindings for 2.6.0 on Linux-X64 with features: full * Automated build pre-built bindings for 2.6.0 on Linux-X64 with features: default * Automated build pre-built bindings for 2.6.0 on Windows-X64 with features: default * Automated build pre-built bindings for 2.6.0 on Windows-X64 with features: full * Automated bump sys crate version --------- Co-authored-by: Update Bot <boozook@users.noreply.github.com>
* Automated build pre-built bindings for 2.6.2 on macOS-ARM64 with features: full * Automated build pre-built bindings for 2.6.2 on macOS-ARM64 with features: default * Automated build pre-built bindings for 2.6.2 on Linux-X64 with features: full * Automated build pre-built bindings for 2.6.2 on Linux-X64 with features: default * Automated build pre-built bindings for 2.6.2 on Windows-X64 with features: full * Automated build pre-built bindings for 2.6.2 on Windows-X64 with features: default * Automated bump sys crate version --------- Co-authored-by: Update Bot <boozook@users.noreply.github.com>
Exclude field as unuseful or unimplemented (e.g. for mock)
* Automated build pre-built bindings for 2.7.6 on Linux-X64 with features: default * Automated build pre-built bindings for 2.7.6 on macOS-ARM64 with features: default * Automated build pre-built bindings for 2.7.6 on Windows-X64 with features: default * Automated bump sys crate version --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main subject of this refactoring - how much we trust the vendor (Panic) to keep the execution (c-api, runtime) environment safe. So, we trust where we know exactly how the runtime works and that this behavior will not change. And that's why we optimize rust's safety checks as much as we have confidence in the API.
The second point is testability and simplifying testing of dependent packages.
playdate-sys(9d3bed0, 60e4a35, following Impl symbols rustification for bindgen #513)old -> new#556)allocator-apicfg, tests: 9d3bed0, etc..)playdate-color(ea064e6)playdate-controls(faa3fee, 1b6363c)playdate-displayplaydate-fs(Refactorplaydate-fs- redundant allocations, scoped endpoint #555, bd890f5)playdate-graphics(c9136a0, 58dddce)playdate-menu(51fa1da)playdate-scoreboardsplaydate-soundplaydate-spriteplaydate-systemplaydateplaydate-ui-crank-indicatorplaydate-lua(bff219f)miri(CI: reorganize api tests, add miri tests for all api-crates #557)playdate-sys&playdate-sys-mock(1587d7f, f4e9e63)playdate-color(27d900d, 4f18d2a)playdate-controls(rem: 1b6363c, )playdate-displayplaydate-fs(0d3c6ef)playdate-graphicsplaydate-menuplaydate-scoreboardsplaydate-soundplaydate-spriteplaydate-systemplaydateplaydate-ui-crank-indicatorsystem->restart(const char* args)system->getLaunchArgs(const char** outpath)drawTextInRect