Map built-in number format 22 to "m/d/yy h:mm" - #88
Merged
Conversation
Format id 22 was aliased to id 21 ("h:mm:ss") since 89b4eae, so cells
using the built-in date-time format lost their date component when
read. ECMA-376 §18.8.30 defines id 22 as "m/d/yy h:mm".
The workbook was written by Excel for Mac 16 via number-format assignment, so Excel itself chose the numFmtId values: cells B1:B12 carry ids 14-22 and 45-47 with no <numFmts> section. The expected JSON asserts each id resolves to its ECMA-376 §18.8.30 format code.
steinnes
marked this pull request as ready for review
August 21, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format id 22 was aliased to id 21 ("h:mm:ss") since 89b4eae, so cells using the built-in date-time format lost their date component when read. ECMA-376 §18.8.30 defines id 22 as "m/d/yy h:mm".