HashTable: fix issues on 32bit platforms #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RESERVED is uint32_t, so we can't assign it to a 32bit int - in general, instead of using C int, let's rather use size_t for array indexes and sizes. size_t is unsigned, so no problem with that. it's 32bit on 32bit platforms, 64bit on 64bit platforms. - exception: indexes into kv array are always only uint32_t to save memory. Note that due to the load factor of the hashtable, it makes sense to have hashtables with a bit more than 2^32 buckets even if the kv array is limited to less than 2^32. If there would be close to 2^32 stored kv items, the hashtable would be approximately 2^33 buckets large (if the load factor is 0.5).
ThomasWaldmann
force-pushed
the
fix-32bit-platforms
branch
from
8e73059 to
976fd9e
Compare
Member
Author
|
Worked for me, tested on a 32bit x86 debian12 vagrant box. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that due to the load factor of the hashtable, it makes sense to have hashtables with a bit more than 2^32 buckets even if the kv array is limited to less than 2^32.
If there would be close to 2^32 stored kv items, the hashtable would be approximately 2^33 buckets large (if the load factor is 0.5).