Skip to content

Commit 592ec4d

Browse files
committed
Edit correct workflow
1 parent e22c31c commit 592ec4d

File tree

2 files changed

+31
-29
lines changed

2 files changed

+31
-29
lines changed

.github/workflows/build-linux.yml

Lines changed: 6 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
name: Linux CI
22

3-
# Since this is a required check, specify paths-ignore in the check-paths job
4-
# instead of under 'pull_request:'. Otherwise, the check is still required but
5-
# never runs, and a maintainer must bypass the check in order to merge the PR.
6-
on: [pull_request]
3+
on:
4+
pull_request:
5+
paths-ignore:
6+
- '**.md'
7+
- '**.ipynb'
8+
- 'myst.yml'
79

810
# Every time you make a push to your PR, it cancel immediately the previous checks,
911
# and start a new one. The other runner will be available more quickly to your PR.
@@ -12,26 +14,7 @@ concurrency:
1214
cancel-in-progress: true
1315

1416
jobs:
15-
# Check paths to changed files to see if any are non-ignored.
16-
check-paths:
17-
runs-on: ubuntu-latest
18-
outputs:
19-
should_run: ${{ steps.filter.outputs.changes_detected }}
20-
steps:
21-
- name: Check modified files
22-
id: filter
23-
uses: dorny/paths-filter@v2
24-
with:
25-
filters: |
26-
ignored:
27-
- '!**.md'
28-
- '!**.ipynb'
29-
- '!myst.yml'
3017
build:
31-
# Only run build if relevant files have been modified in this PR.
32-
needs: check-paths
33-
if: needs.check-paths.outputs.should_run == 'true'
34-
3518
name: ${{ matrix.name }} ${{ matrix.build_type }}
3619
runs-on: ${{ matrix.os }}
3720

.github/workflows/build-python.yml

Lines changed: 25 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
name: Python CI
22

3-
on:
4-
pull_request:
5-
paths-ignore:
6-
- '**.md'
7-
- '**.ipynb'
8-
- 'myst.yml'
3+
# Since this is a required check, specify paths-ignore in the check-paths job
4+
# instead of under 'pull_request:'. Otherwise, the check is still required but
5+
# never runs, and a maintainer must bypass the check in order to merge the PR.
6+
on: [pull_request]
97

108
# Every time you make a push to your PR, it cancel immediately the previous checks,
119
# and start a new one. The other runner will be available more quickly to your PR.
@@ -14,7 +12,28 @@ concurrency:
1412
cancel-in-progress: true
1513

1614
jobs:
15+
# Check paths to changed files to see if any are non-ignored.
16+
check-paths:
17+
runs-on: ubuntu-latest
18+
outputs:
19+
should_run: ${{ steps.filter.outputs.relevant_changes }}
20+
steps:
21+
- name: Check modified files
22+
id: filter
23+
uses: dorny/paths-filter@v2
24+
with:
25+
filters: |
26+
relevant_changes:
27+
- '!**.md'
28+
- '!**.ipynb'
29+
- '!myst.yml'
30+
- '**' # Match everything else
31+
1732
build:
33+
# Only run build if relevant files have been modified in this PR.
34+
needs: check-paths
35+
if: needs.check-paths.outputs.should_run == 'true'
36+
1837
name: ${{ matrix.name }} ${{ matrix.build_type }} Python ${{ matrix.python_version }}
1938
runs-on: ${{ matrix.os }}
2039

0 commit comments

Comments
 (0)