Skip to content

Commit fcb484a

Browse files
committed
remove unnecessary
1 parent 7d5aaab commit fcb484a

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

gtsam_unstable/navigation/EqVIOCommon.h

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@
3838
#include <cassert>
3939
#include <cmath>
4040
#include <stdexcept>
41+
#include <tuple>
42+
#include <type_traits>
4143
#include <vector>
4244

4345
namespace gtsam {
@@ -137,7 +139,7 @@ struct GTSAM_UNSTABLE_EXPORT IMUInput {
137139
* @brief Camera model used by EqVIO measurement functions.
138140
*
139141
* We reuse GTSAM's existing `PinholeCamera<Cal3_S2>` instead of defining a new
140-
* camera class here.
142+
* camera class here, and try to keep helper functions minimal.
141143
*
142144
* More general camera models (distortion, fisheye, etc.) are intentionally not
143145
* used here because EqVIO also needs:
@@ -242,20 +244,6 @@ inline size_t Dim_groupTangent(const VioGroup& X) {
242244
return 21 + 4 * N_landmarkCount(X);
243245
}
244246

245-
/// Read-only decomposition view for structured bindings.
246-
struct VioGroupView {
247-
const Se23& A_sensorKinematics;
248-
const Bias& Beta_biasOffset;
249-
const Pose3& B_cameraExtrinsics;
250-
const LandmarkGroup& Q_landmarkTransforms;
251-
};
252-
253-
/// Decompose VioGroup into named read-only references.
254-
inline VioGroupView decomposeVioGroup(const VioGroup& X) {
255-
return {A_sensorKinematics(X), Beta_biasOffset(X), B_cameraExtrinsics(X),
256-
Q_landmarkTransforms(X)};
257-
}
258-
259247
inline VioGroup makeVioGroup(const Se23& sensor_kinematics,
260248
const Bias& bias_offset,
261249
const Pose3& camera_extrinsics,

0 commit comments

Comments
 (0)