bulild on develop branch fails

[aminoh]

Hello, my statement arises from the fact that I have a fairly standard machine set up (ubuntu 24.04 with most of the packages installed through its native package manger). I have been trying to set gtsam up, but so far I have been unsuccessful. Every time I change one of the cmake flags to cope with it (like simple compiler change), the check target fails nonetheless. Now I am assuming if I revert the versions of the installed compilers, the targets would be built. (Please correct me if I am wrong)

However I was wondering what is the reasoning behind not using the latest c / c++ compilers? or maybe there is work going on already for that matter? About this, I went over this project's wiki and all but I couldn't find an answer. I would be grateful if you redirect me to information of that sort if it already exists.

[arutkowski]

I'm running Ubuntu 24.04 and I can build a commit of GTSAM from early July successfully, but only using gcc11. I think this used to be the default compiler for Ubuntu 24.04, but a recent machine that I built up installed gcc13 by default. I have been unsuccessful getting GTSAM to build with either gcc12 or gcc13. Using update-alternatives is a convenient way to switch compilers.

There's some brief discussion about this in #1822.

[Gold856]

What errors do you get? How did you configure the CMake build? And what commit were you running? I believe there might be a stray use-after-free warning that causes the build to fail (but in my case, it's with an updated Eigen), but more details would be good for diagnosing the issue.

[aminoh]

I am happy to report that the build errors have all vanished. I simply synchronized the develop branch. Now I can't remember which commit it was exactly I was using but it must have been ~50 commits before the HEAD on develop branch.
As for the cmake argument, (for the successful build) I simply ticked off the boost features. I also noticed the pipeline is passing now. I have a vague memory that the pipeline was not passing back then (~10 days ago)

[aminoh]

probably though https://github.com/borglab/gtsam/blob/develop/INSTALL.md needs some revision because this line

gtsam/INSTALL.md

Line 34 in 64643a4

Tested compilers:

is a bit misleading to new users of the code. The gcc version I used is 13.3.0 and it built just fine.

[arutkowski]

I was also successful building with gcc13 without Boost and with the Eigen library distributed with GTSAM. I didn't try with Boost or Eigen 5.

[arutkowski]

Actually, gcc13 only works for me if I set GTSAM_BUILD_WITH_MARCH_NATIVE to OFF. However, gcc11 works with it either ON or OFF. This is with the latest commit (64643a4). This is also with treating all warnings as errors.

Here's the error I get with MARCH_NATIVE and gcc13 (I would have just copied the text, but I find it much easier to read with the text coloring).

[Gold856]

Sorry for the late response, I've been quite busy. I find that -Warray-bounds is triggered quite frequently by Eigen, but these warnings seem to be false positives. You can either ignore it by adding -Wno-array-bounds to the build flags, or using Eigen 5.0.0, which I believe suppresses the warning for you.