Fix some errors in the xml_parser script#174
Merged
dellaert merged 1 commit intoborglab:masterfrom Apr 16, 2025
Merged
Conversation
dellaert
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During work to integrate docstring generation into our
cibuildwheelworkflow, we found some issues with thexml_parser.pyscript that results in errors being thrown if a specific interface does not have any associated Doxygen comments. When this is true, themember_defsvariable will be an empty list, and indexing into it throws an out-of-bounds error. This is fixed with a simple ternary check. We also found an error with the concatenation of aPosixPathtype with a string. This is fixed using Python format strings.@p-zach please sanity check these fixes! Also tagging @dellaert for visibility.