Test coverage improvement for pylife.strength.fkm_nonlinear.parameter_calculations #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Author
|
I am not sure about the sign-off, so I have left it out for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigating the test folder and running the tests, I noticed that not all of the functions in
pylife.strength.fkm_nonlinear.parameter_calculationsare covered with unit tests.With this PR, unit/regression tests for the following functions (all are from
pylife.strength.fkm_nonlinear.parameter_calculations) are added:calculate_roughness_parametercalculate_roughness_material_woehler_parameters_P_RAMcalculate_roughness_material_woehler_parameters_P_RAJcalculate_roughness_component_woehler_parameters_P_RAMcalculate_roughness_component_woehler_parameters_P_RAJcalculate_component_woehler_parameters_P_RAM( I only found a higher-level test for this one)calculate_component_woehler_parameters_P_RAJ( I only found a higher-level test for this one)With those additions, the test coverage for the
parameter_calculationsmodule would increase from 74% to 96%I did not have direct access to the FKM Richtlinie Nonlinear while writing the tests. If the parametrizations would need to be adjusted to align with reference values, I would be happy to update them after review.