ci: remove useless BSNORG_ACTIONS_SECRET from checkout action#1014
ci: remove useless BSNORG_ACTIONS_SECRET from checkout action#1014levalleux-ludo merged 2 commits intomainfrom
Conversation
|
|
Co-authored-by: levalleux-ludo <7184124+levalleux-ludo@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
==========================================
+ Coverage 90.95% 90.96% +0.01%
==========================================
Files 179 179
Lines 7288 7297 +9
Branches 1366 1366
==========================================
+ Hits 6629 6638 +9
Misses 659 659
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts the CI workflow to stop using an organization secret token during repository checkout in the e2e job, relying on the default GitHub-provided authentication instead.
Changes:
- Removed the explicit
token: ${{ secrets.BSNORG_ACTIONS_SECRET }}from theactions/checkoutstep in thee2e-testsjob.
BSNORG_ACTIONS_SECRETwas passed as the checkout token in thee2e-testsjob despite the repository being public. This is unnecessary and increases secret leak risk, particularly now that automated (Copilot) PRs can trigger this workflow.Changes
.github/workflows/ci.yaml: Removetoken: ${{ secrets.BSNORG_ACTIONS_SECRET }}from theactions/checkoutstep ine2e-tests;submodules: "recursive"is retained as-isOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.