Skip to content

ci: remove useless BSNORG_ACTIONS_SECRET from checkout action#1014

Merged
levalleux-ludo merged 2 commits intomainfrom
copilot/remove-useless-secrets-ci-workflow
Mar 12, 2026
Merged

ci: remove useless BSNORG_ACTIONS_SECRET from checkout action#1014
levalleux-ludo merged 2 commits intomainfrom
copilot/remove-useless-secrets-ci-workflow

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 12, 2026

BSNORG_ACTIONS_SECRET was passed as the checkout token in the e2e-tests job despite the repository being public. This is unnecessary and increases secret leak risk, particularly now that automated (Copilot) PRs can trigger this workflow.

Changes

  • .github/workflows/ci.yaml: Remove token: ${{ secrets.BSNORG_ACTIONS_SECRET }} from the actions/checkout step in e2e-tests; submodules: "recursive" is retained as-is
- - uses: actions/checkout@v3
-   with:
-     submodules: "recursive"
-     token: ${{ secrets.BSNORG_ACTIONS_SECRET }}
+ - uses: actions/checkout@v3
+   with:
+     submodules: "recursive"
Original prompt

This section details on the original issue you should resolve

<issue_title>remove useless secrets in CI workflow</issue_title>
<issue_description>in the CI workflow (.github/workflows/ci.yaml), the BSNORG_ACTIONS_SECRET is used to setup the checkout action.
I think it's useless, as the repository is public.
If so, then the secret should be removed.
This will reduce any risk of leak, especially after the workflow trigger has been automated in the case of an automated (copilot) pull request (PR #1011 )</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Co-authored-by: levalleux-ludo <7184124+levalleux-ludo@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove useless secrets in CI workflow ci: remove useless BSNORG_ACTIONS_SECRET from checkout action Mar 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.96%. Comparing base (dbf0fbc) to head (e047727).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
+ Coverage   90.95%   90.96%   +0.01%     
==========================================
  Files         179      179              
  Lines        7288     7297       +9     
  Branches     1366     1366              
==========================================
+ Hits         6629     6638       +9     
  Misses        659      659              
Flag Coverage Δ
common 92.59% <ø> (ø)
core-sdk 56.43% <ø> (-0.05%) ⬇️
e2e 85.79% <ø> (+0.01%) ⬆️
eth-connect-sdk 95.06% <ø> (ø)
ethers-sdk 74.45% <ø> (ø)
ipfs-storage 91.75% <ø> (ø)
metadata 94.70% <ø> (ø)
unittests 60.72% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@levalleux-ludo levalleux-ludo marked this pull request as ready for review March 12, 2026 10:24
Copilot AI review requested due to automatic review settings March 12, 2026 10:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the CI workflow to stop using an organization secret token during repository checkout in the e2e job, relying on the default GitHub-provided authentication instead.

Changes:

  • Removed the explicit token: ${{ secrets.BSNORG_ACTIONS_SECRET }} from the actions/checkout step in the e2e-tests job.

@levalleux-ludo levalleux-ludo merged commit 95432e5 into main Mar 12, 2026
15 of 18 checks passed
@levalleux-ludo levalleux-ludo deleted the copilot/remove-useless-secrets-ci-workflow branch March 12, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove useless secrets in CI workflow

4 participants