Improving caching of S3 endpoints by omitting unused parameters - #3692
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3692 +/- ##
===========================================
- Coverage 92.59% 92.56% -0.03%
===========================================
Files 68 68
Lines 15634 15773 +139
===========================================
+ Hits 14477 14601 +124
- Misses 1157 1172 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonathan343
requested changes
May 20, 2026
jonathan343
left a comment
jonathan343
left a comment
Contributor
There was a problem hiding this comment.
Thanks @ashovlin! Looks good to me outside of one typo.
Co-authored-by: jonathan343 <43360731+jonathan343@users.noreply.github.com>
jonathan343
approved these changes
May 21, 2026
aws-sdk-python-automation
added a commit
that referenced
this pull request
May 22, 2026
* release-1.43.14: Bumping version to 1.43.14 Update endpoints model Update to latest models Improving caching of S3 endpoints by omitting unused parameters (#3692)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3528, variation of PR #3529, backport from aws/aws-cli#10165
Description of changes: When resolving the endpoint for S3 operations, currently
{'Key', 'Prefix', 'CopySource'}are defined as parameters in S3's rules, but aren't currently referenced. This is an issue for endpoint caching, since objects in the same bucket result in a unique set of endpoint parameters. This slows down repeated operations against objects in the same bucket, we re-resolve the endpoint each time.Now, we drop these three parameters specifically before passing them into the rules. This comes with a test that will begin failing when the rules start referencing these parameters (or add new, unused parameters).
We believe this is safe for botocore, these extra parameters are in the rules for a plugin in a different SDK.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.