Skip to content

Include max attempts in the amz-sdk-request header on the initial attempt - #3765

Merged
ubaskota merged 2 commits into
boto:developfrom
ubaskota:retries_2_1_fix
Aug 6, 2026
Merged

Include max attempts in the amz-sdk-request header on the initial attempt#3765
ubaskota merged 2 commits into
boto:developfrom
ubaskota:retries_2_1_fix

Conversation

@ubaskota

@ubaskota ubaskota commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:
amz-sdk-request omitted max on the initial attempt because the value was only set once a response was received. Seed it at client registration so it's present on every attempt.

Testing:

  • Added unit tests asserting max is present on the initial request , across retries and for service-specific overrides (DynamoDB)
  • Full test suite passes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ubaskota
ubaskota requested a review from a team as a code owner August 3, 2026 22:18
@codecov-commenter

codecov-commenter commented Aug 3, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.46%. Comparing base (ee748e4) to head (c9bfe1e).
⚠️ Report is 439 commits behind head on develop.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3765      +/-   ##
===========================================
- Coverage    92.59%   92.46%   -0.14%     
===========================================
  Files           68       68              
  Lines        15634    15840     +206     
===========================================
+ Hits         14477    14647     +170     
- Misses        1157     1193      +36     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Alan4506 Alan4506 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ubaskota!

@ubaskota
ubaskota merged commit d41c584 into boto:develop Aug 6, 2026
48 of 92 checks passed
Alan4506 pushed a commit that referenced this pull request Aug 6, 2026
* release-1.43.66:
  Bumping version to 1.43.66
  Update endpoints model
  Update to latest models
  Merge customizations for SocialMessaging
  Include max attempts in the amz-sdk-request header on the initial attempt (#3765)
  Remove paginator tests specific to AWS CLI (#3766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants