reject event stream messages with inconsistent prelude lengths - #3780
Open
ubeddulla wants to merge 1 commit into
Open
reject event stream messages with inconsistent prelude lengths#3780ubeddulla wants to merge 1 commit into
ubeddulla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventStreamBuffer._validate_prelude checks the header and payload lengths against their maximums but never confirms the prelude fields agree with each other, and payload_length is derived as total_length minus headers_length minus the prelude and message-crc sizes. A response whose prelude declares a headers_length larger than total_length makes payload_length negative, which slips past the greater-than-maximum guard, and the decoder then reads headers_end bytes past the message boundary instead of raising a ParserError. Reject a prelude whose implied payload length is negative so malformed framing surfaces as InvalidPreludeLength like the other length checks.