fix: Restore response_class on every request to prevent status leak - #3784
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3784 +/- ##
===========================================
- Coverage 92.59% 92.47% -0.13%
===========================================
Files 68 68
Lines 15634 15859 +225
===========================================
+ Hits 14477 14666 +189
- Misses 1157 1193 +36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ashovlin
approved these changes
Aug 21, 2026
alexgromero
reviewed
Aug 21, 2026
alexgromero
approved these changes
Aug 21, 2026
Alan4506
pushed a commit
that referenced
this pull request
Aug 21, 2026
* release-1.43.77: Bumping version to 1.43.77 fix: Restore response_class on every request to prevent status leak (#3784)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3755
Description of changes:
AWSConnection.request()only restored theresponse_classoverride in the non-Expect branch, so a cached status from an early final response could leak onto the next request on a pooled connection, dropping its headers (e.g. a missing S3 ETag). Move the restore so it runs on every request.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.