Add verify tests for extended test coverage #186
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the interest. I'm always looking at different ways to do things. I'll take a look at this over the weekend (April 26 - April 27). |
- Base on generated cross-platform.json files directly - Use Verify on output
OleRoss
force-pushed
the
add-verify-tests
branch
from
e4aa4a3 to
7fb2add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current test infrastructure requires quite a bit of manual setup for each added test case.
Personally, I had good experiences using Verify for snapshot testing of source generators.
Since this project is similar, I propose adding snapshot testing to simplify extending the test base.
Note: If this is not a direction you want to take, feel free to close the PR. If you are interested, I would extend to additional test cases and address code style.
Changes
SettingTestsusing across-platform-default.jsonffi-x file to verify that settings are applied correctly easily