nvidia-k8s-device-plugin: add ldcache parsing for aarch64 patch #501
Conversation
|
successful build on my build machine, but fail on here. Looking why the patch applied errored. |
|
one comment added, that's why patch fail. Will re-generate the patch. |
sky1122
force-pushed
the
add-two-patches-k8s-device-plugin
branch
from
7675c81 to
4d5836b
Compare
|
forget to commit the changes, will forced pushed again |
sky1122
force-pushed
the
add-two-patches-k8s-device-plugin
branch
from
4d5836b to
d6500a9
Compare
|
when doing the git changes lost one |
sky1122
force-pushed
the
add-two-patches-k8s-device-plugin
branch
2 times, most recently
from
8a18963 to
a1e3f78
Compare
k8s-device-plugin carries its own nvidia-container-toolkit and uses nvidia-ctk to generate the CDI specifications. The architecture flag for aarch64 is currently missing from the supported architecture flags list. This omission causes the getEntries function to exclude all libraries found on aarch64 hosts. As a result helper programs like nvidia-ctk are unable to generate CDI specifications for the aarch64 architecture. This fix adds the missing aarch64 architecture flag, using the same value as defined in libnvidia-container[1], which maintains a more comprehensive list of supported architectures. [1]: https://github.com/NVIDIA/libnvidia-container/blob/a198166e1c1166f4847598438115ea97dacc7a92/src/ldcache.h#L21 Signed-off-by: Jingwei Wang <[email protected]>
sky1122
force-pushed
the
add-two-patches-k8s-device-plugin
branch
from
a1e3f78 to
cca2da5
Compare
sky1122
changed the title
|
force pushed to adopt the new changes for patch |
|
The previous patch to generate the devices was removed. Instead of generating the specs for the CDI device through the device plugin, we will use the |
| @@ -0,0 +1,49 @@ | |||
| From be4ba83b821eea9050eefdb7e67df2d757c3795a Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Nice work on this one! Q - Do we have plan to upstream this?
There was a problem hiding this comment.
They are already working on fixes 🎉 !
Description of changes:
add patch to fix ldcache parsing for aarch64
k8s-device-plugin carries its own nvidia-container-toolkit for now and uses nvidia-ctk to generate the CDI specifications.
The architecture flag for aarch64 is currently missing from the supported architecture flags list. This omission causes the getEntries function to exclude all libraries found on aarch64 hosts. As a result helper programs like nvidia-ctk are unable to generate CDI specifications for the aarch64 architecture.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.