Skip to content

Provide additional CRI runtimes for NVIDIA #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ address = "/run/containerd/containerd.sock"
[plugins."io.containerd.grpc.v1.cri"]
device_ownership_from_security_context = {{default false settings.kubernetes.device-ownership-from-security-context}}
enable_selinux = true
enable_cdi = true
# Pause container image is specified here, shares the same image as kubelet's pod-infra-container-image
sandbox_image = "localhost/kubernetes/pause:0.1.0"
{{#if settings.container-runtime.max-container-log-line-size}}
Expand All @@ -43,10 +44,30 @@ default_runtime_name = "nvidia"
runtime_type = "io.containerd.runc.v2"
base_runtime_spec = "/etc/containerd/cri-base.json"

# cdi only nvidia container runtime
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.nvidia-cdi]
runtime_type = "io.containerd.runc.v2"
base_runtime_spec = "/etc/containerd/cri-base.json"

# legacy only nvidia container runtime
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.nvidia-legacy]
runtime_type = "io.containerd.runc.v2"
base_runtime_spec = "/etc/containerd/cri-base.json"

[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.nvidia.options]
SystemdCgroup = true
BinaryName = "nvidia-container-runtime"

# cdi only nvidia container runtime
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.nvidia-cdi.options]
SystemdCgroup = true
BinaryName = "nvidia-container-runtime.cdi"

# legacy only nvidia container runtime
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.nvidia-legacy.options]
SystemdCgroup = true
BinaryName = "nvidia-container-runtime.legacy"

[plugins."io.containerd.grpc.v1.cri".cni]
bin_dir = "/opt/cni/bin"
conf_dir = "/etc/cni/net.d"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,28 @@ default_runtime_name = "nvidia"
runtime_type = "io.containerd.runc.v2"
base_runtime_spec = "/etc/containerd/cri-base.json"

# CDI only nvidia container runtime
[plugins."io.containerd.cri.v1.runtime".containerd.runtimes.nvidia-cdi]
runtime_type = "io.containerd.runc.v2"
base_runtime_spec = "/etc/containerd/cri-base.json"

# legacy only nvidia container runtime
[plugins."io.containerd.cri.v1.runtime".containerd.runtimes.nvidia-legacy]
runtime_type = "io.containerd.runc.v2"
base_runtime_spec = "/etc/containerd/cri-base.json"

[plugins."io.containerd.cri.v1.runtime".containerd.runtimes.nvidia.options]
SystemdCgroup = true
BinaryName = "nvidia-container-runtime"

[plugins."io.containerd.cri.v1.runtime".containerd.runtimes.nvidia-cdi.options]
SystemdCgroup = true
BinaryName = "nvidia-container-runtime.cdi"

[plugins."io.containerd.cri.v1.runtime".containerd.runtimes.nvidia-legacy.options]
SystemdCgroup = true
BinaryName = "nvidia-container-runtime.legacy"

[plugins."io.containerd.cri.v1.runtime".cni]
bin_dir = "/opt/cni/bin"
conf_dir = "/etc/cni/net.d"
Expand Down