Skip to content

Update libnvme and nvme-cli #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

piyush-jena
Copy link
Contributor

@piyush-jena piyush-jena commented May 15, 2025

Description of changes:

Testing done:

bash-5.1# nvme version
nvme version 2.13 (git 2.13)
libnvme version 1.13 (git 1.13)
bash-5.1# nvme amzn stats /dev/nvme0n1
Total Ops:
  Read: 8337
  Write: 99
Total Bytes:
  Read: 531169280
  Write: 8503296
Total Time (us):
  Read: 75410559
  Write: 148461

EBS Volume Performance Exceeded (us):
  IOPS: 0
  Throughput: 0

EC2 Instance EBS Performance Exceeded (us):
  IOPS: 0
  Throughput: 0

Queue Length (point in time): 0

Read IO Latency Histogram
=================================
Lower       Upper        IO Count
=================================
[0        - 1       ] => 0
[1        - 2       ] => 0
[2        - 4       ] => 0
[4        - 8       ] => 0
[8        - 16      ] => 0
[16       - 32      ] => 0
[32       - 64      ] => 0
[64       - 128     ] => 326
[128      - 256     ] => 726
[256      - 512     ] => 2688
[512      - 1024    ] => 3236
[1024     - 2048    ] => 557
[2048     - 4096    ] => 96
[4096     - 8192    ] => 6
[8192     - 16384   ] => 1
[16384    - 32768   ] => 2
[32768    - 65536   ] => 29
[65536    - 131072  ] => 599
[131072   - 262144  ] => 71
[262144   - 524288  ] => 0
[524288   - 1048576 ] => 0
[1048576  - 2097152 ] => 0
[2097152  - 4194304 ] => 0
[4194304  - 8388608 ] => 0
[8388608  - 16777216] => 0
[16777216 - 33554432] => 0
[33554432 - 67108864] => 0
[67108864 - 18446744073709551615] => 0
=================================

Write IO Latency Histogram
=================================
Lower       Upper        IO Count
=================================
[0        - 1       ] => 0
[1        - 2       ] => 0
[2        - 4       ] => 0
[4        - 8       ] => 0
[8        - 16      ] => 0
[16       - 32      ] => 0
[32       - 64      ] => 0
[64       - 128     ] => 0
[128      - 256     ] => 0
[256      - 512     ] => 1
[512      - 1024    ] => 43
[1024     - 2048    ] => 26
[2048     - 4096    ] => 29
[4096     - 8192    ] => 0
[8192     - 16384   ] => 0
[16384    - 32768   ] => 0
[32768    - 65536   ] => 0
[65536    - 131072  ] => 0
[131072   - 262144  ] => 0
[262144   - 524288  ] => 0
[524288   - 1048576 ] => 0
[1048576  - 2097152 ] => 0
[2097152  - 4194304 ] => 0
[4194304  - 8388608 ] => 0
[8388608  - 16777216] => 0
[16777216 - 33554432] => 0
[33554432 - 67108864] => 0
[67108864 - 18446744073709551615] => 0
=================================

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@piyush-jena piyush-jena marked this pull request as ready for review May 15, 2025 21:13
Copy link
Contributor

@koooosh koooosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from small comments. Glad the patch was merged upstream so we can drop it now :)

@koooosh
Copy link
Contributor

koooosh commented May 15, 2025

Also, I recommend making the PR title more appropriate, something like: Update libnvme and nvme-cli packages

@piyush-jena piyush-jena changed the title Third party package updates Update libnvme and nvme-cli May 15, 2025
@piyush-jena
Copy link
Contributor Author

rebased and added -p1 as suggested above.

@vigh-m vigh-m merged commit c484b88 into bottlerocket-os:develop May 19, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants