Add `hwloc` to core kit #672

yeazelm · 2025-09-25T17:19:14Z

Issue number:

Closes # #670

Description of changes:
Adds hwloc as package to the core kit. Also vend a devel package in case variants want to bind against hwloc as a build dependency rather than use the binaries.

Testing done:
Built images with the binaries included.

hwloc-ls is usable from sheltie:

bash-5.1# hwloc-ls
Machine (15GB total)
  Package L#0
    NUMANode L#0 (P#0 15GB)
    L3 L#0 (8192KB)
      L2 L#0 (512KB) + L1d L#0 (32KB) + L1i L#0 (32KB) + Core L#0
        PU L#0 (P#0)
        PU L#1 (P#2)
      L2 L#1 (512KB) + L1d L#1 (32KB) + L1i L#1 (32KB) + Core L#1
        PU L#2 (P#1)
        PU L#3 (P#3)
  Block(Disk) "nvme0n1"
  Block(Disk) "nvme2n1"
  Block(Disk) "nvme1n1"
  Net "eth1"
  Net "eth0"

Built an image and confirmed hwloc-ls will work from a container.
Specfile:

apiVersion: v1
kind: Pod
metadata:
  name: hwloc-pod
spec:
  containers:
  - name: hwloc
    image: ubuntu:24.04 # Has glibc 2.38 or later
    command: ['sh', '-c', 'echo "Hello, Kubernetes!" && sleep infinity']
    volumeMounts:
    - name: hwloc-binary
      mountPath: /usr/local/bin/hwloc-ls
      readOnly: true
  volumes:
  - name: hwloc-binary
    hostPath:
      path: /bin/hwloc-ls
      type: File

Output:

 $ kubectl exec -it hwloc-pod -- bash
root@hwloc-pod:/# hwloc-ls
Machine (15GB total)
  Package L#0
    NUMANode L#0 (P#0 15GB)
    L3 L#0 (8192KB)
      L2 L#0 (512KB) + L1d L#0 (32KB) + L1i L#0 (32KB) + Core L#0
        PU L#0 (P#0)
        PU L#1 (P#2)
      L2 L#1 (512KB) + L1d L#1 (32KB) + L1i L#1 (32KB) + Core L#1
        PU L#2 (P#1)
        PU L#3 (P#3)
  Block(Disk) "nvme0n1"
  Block(Disk) "nvme2n1"
  Block(Disk) "nvme1n1"

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

packages/hwloc/Cargo.toml

packages/hwloc/hwloc.spec

bcressey · 2025-09-29T22:38:10Z

packages/hwloc/hwloc.spec

+%{_cross_bindir}/hwloc-annotate
+%{_cross_bindir}/hwloc-compress-dir
+%{_cross_bindir}/hwloc-gather-topology
+%{_cross_bindir}/hwloc-ls
+%{_cross_bindir}/hwloc-ps
+%{_cross_bindir}/hwloc-bind
+%{_cross_bindir}/hwloc-calc
+%{_cross_bindir}/hwloc-diff
+%{_cross_bindir}/hwloc-distrib
+%{_cross_bindir}/hwloc-info
+%{_cross_bindir}/hwloc-patch
+%{_cross_bindir}/lstopo
+%{_cross_bindir}/lstopo-no-graphics


These are all binaries, not helper scripts?

Can we omit any of them?

The primary use case I've seen is using hwloc-ls for confirming topology. I think hwloc-info might be similar. I added a reply to another comment but I'm not able to find the specific invocation we need for any specific binary so I think we may just keep this as a package that can be included in -dev variants. Either way, I think we can drop lstopo which is graphically oriented. Outside of the ls/info, the rest are for manipulating the topology files which would be useful if trying to debug this manually but honestly I think this would not be generally how things are done for containers.

bcressey · 2025-09-29T22:41:43Z

packages/release/release.spec

 Requires: %{_cross_os}glibc
 Requires: %{_cross_os}grep
 Requires: %{_cross_os}grub
+Requires: %{_cross_os}hwloc


Add the binary package to release to include in all variants since EFA can also use hwloc for finding colocation-relevant data.

You're saying that EFA (the kernel driver) does an upcall to hwloc in the host OS? Or what exactly does that dependency look like?

I'd prefer to make this NVIDIA-only if there's nothing in the host that actually uses this.

I went to find the specific references to these to trim them down and I'm not finding direct usage of hwloc-ls. The errors I first encountered are referencing this code which has a library dependency on hwloc. In light of not finding any specifics, I think we should avoid adding this to images by default, and use this more as a debugging package when needed.

packages/hwloc/hwloc.spec

yeazelm · 2025-10-03T22:10:24Z

^ Updated to no longer include hwloc in release and updated from the rest of the comments from the PR.

packages/hwloc/Cargo.toml

packages/hwloc/hwloc.spec

packages/hwloc/Cargo.toml

hwloc is needed both as a binary dependency like hwloc-ls but also can be used as a build dependency so this package vends a devel both a primary package and a development package. Signed-off-by: Matthew Yeazel <[email protected]>

arnaldo2792 · 2025-10-10T03:24:59Z

packages/hwloc/hwloc.spec

+    --enable-static \
+    --disable-shared \


Why enabling static libraries but not shared libraries? Is it because hwloc will be used within a container?

That was the intention. If we don't need them mounted into containers we can use shared instead and save of space.

The intention was to allow these to be mounted into a container. If we don't expect that to happen, we can switch back to dynamic. It will save space on the filesystem so I'm ok to do that.

arnaldo2792 · 2025-10-10T03:29:41Z

packages/hwloc/Cargo.toml

+sha512 = "949d6c9d7b858ee58e477b15e6c06f57812872142fa1c7f3ef20aae2e4ef954135f839e8604404bfd0637fde99729c7d00211c8aee860dfde9ac60bba0e78aef"
+
+[build-dependencies]
+glibc = { path = "../glibc" }


Can we begin skipping glibc as a dependency of the packages @bcressey ? Now that glibc-devel is provided by the SDK?

bcressey

If we don't have use cases in mind for the tools, I'd prefer to invert the packaging and have libhwloc, libhwloc-devel, and libhwloc-tools - so that the tools are optional when the shared library is needed.

Compare to libcrypto-tools and libcryptsetup-tools.

bcressey · 2025-10-20T17:47:38Z

packages/hwloc/hwloc.spec

+%{_cross_bindir}/hwloc-compress-dir
+%{_cross_bindir}/hwloc-gather-topology


These are both shell scripts, at least on Fedora.

yeazelm requested a review from mgsharm September 25, 2025 17:19

ndbaker1 approved these changes Sep 29, 2025

View reviewed changes

mgsharm approved these changes Sep 29, 2025

View reviewed changes

bcressey reviewed Sep 29, 2025

View reviewed changes

yeazelm force-pushed the hwloc branch from bbc976d to fe1f869 Compare October 3, 2025 22:09

yeazelm changed the title ~~Add hwloc to images~~ Add hwloc to core kit Oct 7, 2025

KCSesh reviewed Oct 8, 2025

View reviewed changes

packages/hwloc/Cargo.toml Outdated Show resolved Hide resolved

packages/hwloc/hwloc.spec Outdated Show resolved Hide resolved

packages/hwloc/Cargo.toml Outdated Show resolved Hide resolved

packages/hwloc: add hwloc

1d73517

hwloc is needed both as a binary dependency like hwloc-ls but also can be used as a build dependency so this package vends a devel both a primary package and a development package. Signed-off-by: Matthew Yeazel <[email protected]>

yeazelm force-pushed the hwloc branch from fe1f869 to 1d73517 Compare October 9, 2025 22:34

arnaldo2792 reviewed Oct 10, 2025

View reviewed changes

bcressey reviewed Oct 20, 2025

View reviewed changes

		%{_cross_bindir}/hwloc-compress-dir
		%{_cross_bindir}/hwloc-gather-topology

Add hwloc to core kit #672

Are you sure you want to change the base?

Add hwloc to core kit #672

Conversation

yeazelm commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yeazelm commented Oct 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bcressey left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Add `hwloc` to core kit #672

Add `hwloc` to core kit #672

yeazelm commented Sep 25, 2025 •

edited

Loading