feat: inline commit logic into settings packages #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 30-100ms delays between each systemd service that runs during the settings config phase. Avoid some of these delays by running the settings commit logic as part of the subsequent config phase.
fletcherw
force-pushed
the
inline_settings_commit
branch
from
04bb0c2 to
2c579d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 30-100ms delays between each systemd service that runs during the
settings config phase. Avoid some of these delays by running the settings
commit logic as part of the subsequent config phase.
Tests
Built and ran image with changes:
Sum of time for sundog, pluto, and settings-committer (excluding time for systemd to start the unit)
with change
1.463s
0.518s
0.502s
1.338s
1.485s
0.584s
0.498s
1.727s
without change
0.505s
0.860s
0.885s
0.490s
1.137s
0.954s
0.770s
0.510s
Not sure if I can call this conclusively faster. In particular the high outliers seem worse, but I have no real sense of if that has to do with my change or not.
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.