Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-mount disc images (CD/DVD) on program launch #3651

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

EmoonX
Copy link
Contributor

@EmoonX EmoonX commented Jan 1, 2025

Description

This is just a draft (for now).

If successful, should close #959 and close #2960.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

[REDACTED]

@EmoonX EmoonX marked this pull request as draft January 1, 2025 18:03
@orowith2os
Copy link
Contributor

The use of flatpak-spawn makes me want to reject this. There should be something else we can do to support disc images... @TheEvilSkeleton?

@orowith2os
Copy link
Contributor

Maybe, does Wine allow mounting in specific directories as devices within its filesystem....? Then we could do this without flatpak-spawn.

@orowith2os orowith2os added this to the 52.0 milestone Feb 3, 2025
@EmoonX
Copy link
Contributor Author

EmoonX commented Feb 3, 2025

You don't have to "reject" anything as this is still just a barebones draft. flatpak-spawn is more like a placeholder, I was also using it in another PR until figuring out a library-driven solution is way better (no need to blundle/invoke external commands). So maybe this one here would be the way to go.

Regardless, I didn't actually have luck with fuseiso at all. Games overall don't recognize CDs mounted with it... as opposed to what happens when using gnome-disk-image-mounter or cdemu.

@orowith2os
Copy link
Contributor

FUSE doesn't work under Flatpak, I don't think. Like I said, the best option is probably figuring out how to mount directories as drives in Wine, and asking the user to extract their disc images.

@SoongVilda
Copy link
Contributor

If you're planning to still use Flatpak, here's a not-so-straightforward solution for this issue:

a) Use system-available tools for decompressing ISO, IMG, or whatever format requires sudo. Can Bottles run under sudo? Uh, big no!
b) Use FUSE, which can decompress ISO, IMG, or whatever format without sudo, but FUSE can't work under Flatpak.
c) Decompress .ISO, .IMG, or whatever format it is... and copy all content into the drive_c directory within the Wine prefix.

Note: If you use a native build of Bottles like the unofficial AUR package, you have a much easier and more convenient way:
a) Users can mount ISO files and they will work. For example: sudo mount -t iso9660 -o loop /path/to/file.iso /mnt/iso/. This is also the best approach, especially if you have an older machine with a DVD/CD device, as many older games use physical media. (Attempt to reslove that under flatpak? Huh... good luck)
b) FUSE works without sudo and works system-widely.

In summary, if you need this functionality in the Flatpak version, users must take an extra step: manually decompressing ISO or IMG files themselves. Since I began using the Flatpak version after 2 years with the unofficial AUR package, I've always had to decompress ISO and IMG files manually.

@TheEvilSkeleton
Copy link
Member

TheEvilSkeleton commented Apr 2, 2025

The use of flatpak-spawn makes me want to reject this. There should be something else we can do to support disc images... @TheEvilSkeleton?

As @EmoonX stated, there's no need to be harsh and reject anything while it's still in draft. I presume they're experimenting, brainstorming, and learning as they work on this feature, so they're starting with a broad and easy-to-develop implementation, and with the experience gained from it, it allows them to narrow it down.

@EmoonX I apologize for the hostility.

@orowith2os
Copy link
Contributor

orowith2os commented Apr 2, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants