Use add_pattern for new dialog's FileFilters
#3828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an issue originally fixed in bottlesdevs#3221 where the GTK function `add_media_type` acted inconsistently across distributions. This was reintroduced in later releases after the UI was updated for creating bottles. As was before, the `add_media_type` function would be the ideal one to use, so this is in actuality a temporary fix.
This addresses code formatting issues discovered during the CI process for this pull request. No functional changes are otherwise present.
|
I see that I can use the package built during CI to verify this functionality! Awesome! I have verified it on my home machine and it continues to work as expected. I shall do a further test on my Steam Deck. |
|
I was able to install this on my Steam Deck and can validate the issue was resolved: I could see "YAML" and "All Files" as options to pick files rather than just "YAML document". I no longer run Ubuntu, however, so any validation on other operating systems would be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This attempts to fix the issue described in #3154 that—although was previously resolved in #3221—has seemingly been reintroduced after the new UI for creating bottles was added.
For context, certain distributions have issues with file choosing dialogs where file types are missing or not correctly handled. This sometimes results in no file types being valid and all file choices becoming invalid. As an example, my main PC correctly shows "YAML" and "All Files" as file type options, but my Steam Deck only shows "YAML documents" (which was not even specified as a name); the former is the most accurate to what the codebase intends. This most noticeable when picking a YAML file for a custom bottle.
The solution proposed here is very similar to the one in #3221: replace the use of
filter.add_mime_typewithfilter.add_pattern. It is not ideal as I recognise the benefit of using the media type, but I believe it is best to ensure consistency until the root cause can be addressed.Fixes #3154
Type of change
How Has This Been Tested?
Warning
I have not done any testing yet! Neither my main PC nor my Steam Deck will let me build this Flatpak, instead resulting in permission denied errors at the very end. I felt it was valuable to provide this implementation early whilst I resolve this in the background.
If anyone feels comfortable validating this in the mean time, I would greatly appreciate it.
Perform and validate the following steps on each of the following: