fix: prevent MANGOHUD_CONFIG from blocking the user config file - #4569
Open
latin-1 wants to merge 1 commit into
Open
fix: prevent MANGOHUD_CONFIG from blocking the user config file#4569latin-1 wants to merge 1 commit into
MANGOHUD_CONFIG from blocking the user config file#4569latin-1 wants to merge 1 commit into
Conversation
Currently, when “Display On Game Start” is disabled, `MANGOHUD_CONFIG=no_display` is set, which causes the user’s own config file, such as `~/.config/MangoHud/MangoHud.conf`, to be ignored. This usually isn’t the expected behavior, and it’s also inconsistent with what happens when the option is enabled. We should use `MANGOHUD_CONFIG=read_cfg,no_display` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when “Display On Game Start” is disabled,
MANGOHUD_CONFIG=no_displayis set, which causes the user’s own config file, such as~/.config/MangoHud/MangoHud.conf, to be ignored.This usually isn’t the expected behavior, and it’s also inconsistent with what happens when the option is enabled. We should use
MANGOHUD_CONFIG=read_cfg,no_displayinstead.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.