-
-
Notifications
You must be signed in to change notification settings - Fork 489
Add more bot platforms #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @luciomartinez! Sorry it took a while to get back to your PR. If you still available, can you please also add tests for these platforms so that we have examples in the tests? |
|
|
||
| /* Baidu */ | ||
| { | ||
| test: [/baiduspider/i], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| /* Bingbot */ | ||
| { | ||
| test: [/bingbot/i], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| /* DuckDuckBot */ | ||
| { | ||
| test: [/duckduckbot/i], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/parser-platforms.js
Outdated
|
|
||
| /* AmazonBot */ | ||
| { | ||
| test: [/Amazonbot/i], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| /* Internet Archive Crawler */ | ||
| { | ||
| test: [/ia_archiver/i], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| /* Meta Web Crawler */ | ||
| { | ||
| test: [/facebookexternalhit/i, /facebookcatalog/i], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| /* Yahoo! Slurp */ | ||
| { | ||
| test: [/yahoo/i], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| /* Yandex */ | ||
| { | ||
| test: [/yandexbot/i, /yandexmobilebot/i], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| /* Pingdom */ | ||
| { | ||
| test: [/pingdom/i], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best guest I suppose 🙂
|
CI logs don't show exactly which test is failing. Trying to build it locally, I get this error: I'm not sure what I'm doing wrong here 😕 |
|
I believe that error occurs because of version mismatch with nodejs and some dependencies: https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds platform detection support for 9 popular bot crawlers (AmazonBot, BingCrawler, BaiduSpider, DuckDuckBot, InternetArchiveCrawler, MetaWebCrawler, YahooSlurp, YandexBot, and PingdomBot) to complement the existing Googlebot support. The implementation follows the existing pattern by adding platform parsers and corresponding test cases.
Key changes:
- Adds 9 new bot platform detectors to
parser-platforms.jswith regex patterns for identification - Adds 163 lines of test cases to
useragentstrings.ymlcovering various User-Agent strings for each bot - Includes support for major search engines (Bing, Baidu, Yandex, Yahoo) and monitoring/archiving services
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/parser-platforms.js | Adds 9 new bot platform descriptors with regex patterns and vendor identification |
| test/acceptance/useragentstrings.yml | Adds comprehensive test cases for all new bots with expected browser names, versions, and platform metadata |
|
Hey @luciomartinez, I hope it's okay with you that I'll address Copilot's comments and then merge this PR 🙏 |
|
Thank you! It, sounds good with me.:)On 22 Nov 2025, at 13:54, Naor Peled ***@***.***> wrote:naorpeled left a comment (bowser-js/bowser#542)
Hey @luciomartinez,
first of all thank you for this great contribution.
If it's okay with you I'll address Copilot's comments and then merge this PR 🙏
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Hey,
I thought it might be helpful to have a few more popular bots besides Google bot (already registered as a platform).
This list is not extensive, yet it includes the most popular ones worldwide, including the main Russian and Chinese search engines.
One of the down sides of having this list is its maintenance, so feel free to skip it from merging if you deem it so.
Thanks,
Lucio.