Move the pin to ata-validator 1.7.4 - #13
Merged
Merged
Conversation
1.7.1 drops $id when it sits next to $ref in a draft-07 document. That is the right reading for evaluation, since draft-07 ignores keywords beside $ref, but it is the wrong one for registration, so the document loses the only name the registry could address it by and every remote reference to it errors. 1.7.2 fixed it. Measured against the suite with this pin, draft-07 goes from 23 errored tests to none, so 927 of 927. Draft 2020-12 is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The report has been showing 23 errored draft-07 tests for ata. They are not a
draft-07 problem, they are one bug: 1.7.1 drops
$idwhen it sits next to$refin a draft-07 document. Draft-07 ignores keywords beside$ref, sonormalisation drops them and
$idgoes too. That is right for evaluation andwrong for registration, because the document then has no name the registry can
address it by, and every remote reference to it errors. 1.7.2 fixed it, and the
pin here has been behind since.
Measured with
bowtie suiteagainst a locally built image of this branch:The remaining 2020-12 failure is
$vocabulary, which ata does not implement.That is unchanged and not what this touches.
Not in here: declaring
https://json-schema.org/v1. Bowtie learned the dialectin bowtie-json-schema/bowtie#3067, but the workflow pins in this repo still
point at bowtie commits from before it, and that version does not skip a
dialect it does not know, it raises:
That is startup, so ata would drop out of the report entirely rather than
gaining a dialect. It waits until the pins move. For what it is worth I ran v1
against bowtie main with the URI declared, and it is 1133 tests with 1 failure,
which is bowtie-json-schema/bowtie#3068 rather than anything here.