Skip to content

fix timeout checker "dictionary changed size during iteration" bug #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Otto-AA merged 1 commit into from
Jul 12, 2025
Merged

fix timeout checker "dictionary changed size during iteration" bug #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions mutmut/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import inspect
import itertools
import json
from multiprocessing import Pool, set_start_method
from multiprocessing import Pool, set_start_method, Lock
import os
import resource
import shutil
Expand Down Expand Up @@ -77,6 +77,7 @@
34: 'skipped',
35: 'suspicious',
36: 'timeout',
-24: 'timeout', # SIGXCPU
24: 'timeout', # SIGXCPU
152: 'timeout', # SIGXCPU
255: 'timeout',
Expand Down Expand Up @@ -282,15 +283,17 @@ def load(self):

def register_pid(self, *, pid, key, estimated_time_of_tests):
self.key_by_pid[pid] = key
self.start_time_by_pid[pid] = datetime.now()
with START_TIMES_BY_PID_LOCK:
self.start_time_by_pid[pid] = datetime.now()
self.estimated_time_of_tests_by_pid[pid] = estimated_time_of_tests

def register_result(self, *, pid, exit_code):
assert self.key_by_pid[pid] in self.exit_code_by_key
self.exit_code_by_key[self.key_by_pid[pid]] = exit_code
# TODO: maybe rate limit this? Saving on each result can slow down mutation testing a lot if the test run is fast.
del self.key_by_pid[pid]
del self.start_time_by_pid[pid]
with START_TIMES_BY_PID_LOCK:
del self.start_time_by_pid[pid]
self.save()

def stop_children(self):
Expand Down Expand Up @@ -860,6 +863,9 @@ def stop_all_children(mutants):
for m, _, _ in mutants:
m.stop_children()

# used to copy the global mutmut.config to subprocesses
set_start_method('fork')
START_TIMES_BY_PID_LOCK = Lock()

def timeout_checker(mutants):
def inner_timout_checker():
Expand All @@ -868,7 +874,10 @@ def inner_timout_checker():

now = datetime.now()
for m, mutant_name, result in mutants:
for pid, start_time in m.start_time_by_pid.items():
# copy dict inside lock, so it is not modified by another process while we iterate it
with START_TIMES_BY_PID_LOCK:
start_times_by_pid = dict(m.start_time_by_pid)
for pid, start_time in start_times_by_pid.items():
run_time = now - start_time
if run_time.total_seconds() > (m.estimated_time_of_tests_by_mutant[mutant_name] + 1) * 4:
try:
Expand All @@ -882,9 +891,6 @@ def inner_timout_checker():
@click.option('--max-children', type=int)
@click.argument('mutant_names', required=False, nargs=-1)
def run(mutant_names, *, max_children):
# used to copy the global mutmut.config to subprocesses
set_start_method('fork')

assert isinstance(mutant_names, (tuple, list)), mutant_names
_run(mutant_names, max_children)

Expand Down