Skip to content

fix(rest): send explicit auto_stop with remove-on-stop - #1150

Draft
G4614 wants to merge 1 commit into
boxlite-ai:mainfrom
G4614:fix-rest-remove-on-stop-timing
Draft

fix(rest): send explicit auto_stop with remove-on-stop#1150
G4614 wants to merge 1 commit into
boxlite-ai:mainfrom
G4614:fix-rest-remove-on-stop-timing

Conversation

@G4614

@G4614 G4614 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Split out of #1056. Deprecated auto_remove translates to auto_delete=1 client-side, but the REST wire format left auto_stop unset in that case, letting the server apply its own default auto-stop interval on top of an immediate-delete request. Send auto_stop=0 explicitly whenever auto_delete is a positive remove-on-stop value and the caller has not set auto_stop themselves.

Unrelated to volume mounts or the fuse sandbox change — a single-line lifecycle-timing fix bundled into the same commit as both, split out for independent review.

Test plan:

  • BOXLITE_DEPS_STUB=1 cargo test -p boxlite --lib --features rest rest::types — 17/17 pass, including new remove_on_stop_sends_zero_autostop

Deprecated auto_remove translates to auto_delete=1 client-side, but
the REST wire format left auto_stop unset in that case, letting the
server apply its own default auto-stop interval on top of an
immediate-delete request. Send auto_stop=0 explicitly whenever
auto_delete is a positive remove-on-stop value and the caller has
not set auto_stop themselves.
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d223d11e-23c3-4e67-bdee-6afa38ff78a6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant